linux-kernel - Re: [PATCH 13/26] drm/omap: omap_display_timings: Use display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Sep 2016 15:06:38 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>, <thierry.reding@...il.com>,
        <airlied@...ux.ie>
CC:     <daniel.vetter@...ll.ch>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/26] drm/omap: omap_display_timings: Use display_flags
 for interlace mode

On 01/09/16 14:23, Peter Ujfalusi wrote:
> Remove the interlace member and add display_flags to omap_video_timings to
> configure the interlace mode.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---


> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index aca9d3028155..97acc340dcd5 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -323,8 +323,6 @@ struct omap_video_timings {
>  	enum omap_dss_signal_level vsync_level;
>  	/* Hsync logic level */
>  	enum omap_dss_signal_level hsync_level;
> -	/* Interlaced or Progressive timings */
> -	bool interlace;
>  	/* Pixel clock edge to drive LCD data */
>  	enum omap_dss_signal_edge data_pclk_edge;
>  	/* Data enable logic level */
> @@ -333,6 +331,8 @@ struct omap_video_timings {
>  	enum omap_dss_signal_edge sync_pclk_edge;
>  
>  	bool double_pixel;
> +
> +	enum display_flags flags; /* display flags */

The comment here feels a bit pointless.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)