linux-kernel - Re: [PATCH v2] clk: probe common clock drivers earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Sep 2016 16:53:51 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     linux-clk <linux-clk@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <sboyd@...eaurora.org>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Jay Sternberg <jay.e.sternberg@...el.com>,
        Jens Axboe <axboe@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matias Bjørling <m@...rling.me>,
        Krzysztof Kozlowski <k.kozlowski@...sung.com>,
        Alan Tull <atull@...nsource.altera.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Valentin Rothberg <valentinrothberg@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v2] clk: probe common clock drivers earlier

Hi Stephen, Greg,


2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> Several SoCs implement platform drivers for clocks rather than
> CLK_OF_DECLARE().  Clocks should come earlier because they are
> prerequisites for many of other drivers.  It will help to mitigate
> EPROBE_DEFER issues.
>
> Also, drop the comment since it does not look valuable.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
> Changes in v2:
>   - Move clk/ above dma/ since DMA drivers generally enable clk
>
>  drivers/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 8f5d076..ff39051 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
>  # was used and do nothing if so
>  obj-$(CONFIG_PNP)              += pnp/
>  obj-y                          += amba/
> +
> +obj-y                          += clk/
>  # Many drivers will want to use DMA so this has to be made available
>  # really early.
>  obj-$(CONFIG_DMADEVICES)       += dma/
> @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
>  obj-$(CONFIG_VLYNQ)            += vlynq/
>  obj-$(CONFIG_STAGING)          += staging/
>  obj-y                          += platform/
> -#common clk code
> -obj-y                          += clk/
>
>  obj-$(CONFIG_MAILBOX)          += mailbox/
>  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/


What do you think of this patch?


Linus game me a positive comment:
https://lkml.org/lkml/2016/7/15/722



-- 
Best Regards
Masahiro Yamada