linux-kernel - Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Sep 2016 10:28:38 -0500
From:   Rob Herring <robh@...nel.org>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Neil Armstrong <narmstrong@...libre.com>, khilman@...libre.com,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        broonie@...nel.org, carlo@...one.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

On Thu, Sep 08, 2016 at 02:50:37PM +0200, Andreas Färber wrote:
> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
> > Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
> >> This patchset adds a specific compatible string in the Meson SPIFC driver for
> >> the Amlogic Meson GXBB SoC.
> > 
> > Any particular reason? We could just reuse the meson6 one since there
> > appear to be no code changes so far.
> 
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
> 
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)

New chip, always define a new compatible. If you think they are the same 
or are close enough to function with the existing driver, then put both 
compatible strings in the DT.

Rob