linux-kernel - Re: [PATCH] ALSA: hdac: add missing \n to end of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Sep 2016 19:24:54 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Colin King" <colin.king@...onical.com>
Cc:     <alsa-devel@...a-project.org>, "Jeeja KP" <jeeja.kp@...el.com>,
        "Subhransu S . Prusty" <subhransu.s.prusty@...el.com>,
        "Vinod Koul" <vinod.koul@...el.com>,
        "Mark Brown" <broonie@...nel.org>, <trivial@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hdac: add missing \n to end of dev_err messages

On Fri, 16 Sep 2016 18:36:05 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Trival fix, some dev_err messages are missing a \n, so add it.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.


Takashi

> ---
>  sound/hda/ext/hdac_ext_stream.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c
> index 2441273..3be051a 100644
> --- a/sound/hda/ext/hdac_ext_stream.c
> +++ b/sound/hda/ext/hdac_ext_stream.c
> @@ -424,7 +424,7 @@ void snd_hdac_ext_stream_spbcap_enable(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->spbcap) {
> -		dev_err(bus->dev, "Address of SPB capability is NULL");
> +		dev_err(bus->dev, "Address of SPB capability is NULL\n");
>  		return;
>  	}
>  
> @@ -453,7 +453,7 @@ int snd_hdac_ext_stream_set_spib(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->spbcap) {
> -		dev_err(bus->dev, "Address of SPB capability is NULL");
> +		dev_err(bus->dev, "Address of SPB capability is NULL\n");
>  		return -EINVAL;
>  	}
>  
> @@ -476,7 +476,7 @@ int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->spbcap) {
> -		dev_err(bus->dev, "Address of SPB capability is NULL");
> +		dev_err(bus->dev, "Address of SPB capability is NULL\n");
>  		return -EINVAL;
>  	}
>  
> @@ -516,7 +516,7 @@ void snd_hdac_ext_stream_drsm_enable(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->drsmcap) {
> -		dev_err(bus->dev, "Address of DRSM capability is NULL");
> +		dev_err(bus->dev, "Address of DRSM capability is NULL\n");
>  		return;
>  	}
>  
> @@ -545,7 +545,7 @@ int snd_hdac_ext_stream_set_dpibr(struct hdac_ext_bus *ebus,
>  	struct hdac_bus *bus = &ebus->bus;
>  
>  	if (!bus->drsmcap) {
> -		dev_err(bus->dev, "Address of DRSM capability is NULL");
> +		dev_err(bus->dev, "Address of DRSM capability is NULL\n");
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.9.3
> 
>