linux-kernel - Re: [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up

Open Source and information security mailing list archives

Date:   Fri, 16 Sep 2016 15:30:31 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <christian.koenig@....com>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Chunming Zhou <David1.Zhou@....com>,
        "monk.liu" <Monk.Liu@....com>, Rex Zhu <Rex.Zhu@....com>,
        Eric Huang <JinHuiEric.Huang@....com>,
        Flora Cui <Flora.Cui@....com>,
        "Daenzer, Michel" <michel.daenzer@....com>, xie.baoyou@....com.cn,
        Arnd Bergmann <arnd@...db.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up

On Thu, Sep 15, 2016 at 9:49 AM, Christian König
<christian.koenig@....com> wrote:
> Am 15.09.2016 um 15:43 schrieb Baoyou Xie:
>>
>> We get 2 warnings when building kernel with W=1:
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:985:5: warning: no previous
>> prototype for 'amdgpu_ttm_init' [-Wmissing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1092:6: warning: no previous
>> prototype for 'amdgpu_ttm_fini' [-Wmissing-prototypes]
>>
>> In fact, both functions are declared in
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c, but should be declared in
>> a header file, thus can be recognized in other file.
>>
>> So this patch moves the declarations into
>> drivers/gpu/drm/amd/amdgpu/amdgpu.h.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
>
>
> Reviewed-by: Christian König <christian.koenig@....com>.

Applied.  thanks!

Alex

>
>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 2 ++
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 --
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> index a7bb862..3208608 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> @@ -2402,6 +2402,8 @@ void amdgpu_gtt_location(struct amdgpu_device *adev,
>> struct amdgpu_mc *mc);
>>   void amdgpu_ttm_set_active_vram_size(struct amdgpu_device *adev, u64
>> size);
>>   u64 amdgpu_ttm_get_gtt_mem_size(struct amdgpu_device *adev);
>>   int amdgpu_ttm_global_init(struct amdgpu_device *adev);
>> +int amdgpu_ttm_init(struct amdgpu_device *adev);
>> +void amdgpu_ttm_fini(struct amdgpu_device *adev);
>>   void amdgpu_program_register_sequence(struct amdgpu_device *adev,
>>                                              const u32 *registers,
>>                                              const u32 array_size);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index b17734e..30f05d8 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -38,8 +38,6 @@
>>   #include "amdgpu_trace.h"
>>     -int amdgpu_ttm_init(struct amdgpu_device *adev);
>> -void amdgpu_ttm_fini(struct amdgpu_device *adev);
>>     static u64 amdgpu_get_vis_part_size(struct amdgpu_device *adev,
>>                                                 struct ttm_mem_reg *mem)
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives