linux-kernel - Re: [PATCH] drm/amdgpu: amend amdgpu_gfx_parse_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2016 12:00:45 +0200
From:   Christian König <christian.koenig@....com>
To:     Baoyou Xie <baoyou.xie@...aro.org>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "Haehnle, Nicolai" <Nicolai.Haehnle@....com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "xie.baoyou@....com.cn" <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm/amdgpu: amend amdgpu_gfx_parse_disable_cu()
 declaration

Am 18.09.2016 um 15:37 schrieb Baoyou Xie:
> In amdgpu_gfx.h, the declaration of amdgpu_gfx_parse_disable_cu()
> is incorrect.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Ups, nice catch.

Patch is Reviewed-by: Christian König <christian.koenig@....com>.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +++-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 5 ++++-
>   2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 01a42b6..8575039 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -82,7 +82,9 @@ void amdgpu_gfx_scratch_free(struct amdgpu_device *adev, uint32_t reg)
>    * The bitmask of CUs to be disabled in the shader array determined by se and
>    * sh is stored in mask[se * max_sh + sh].
>    */
> -void amdgpu_gfx_parse_disable_cu(unsigned *mask, unsigned max_se, unsigned max_sh)
> +void amdgpu_gfx_parse_disable_cu(unsigned int *mask,
> +				unsigned int max_se,
> +				unsigned int max_sh)
>   {
>   	unsigned se, sh, cu;
>   	const char *p;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> index 51321e1..0b9ad4f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> @@ -27,6 +27,9 @@
>   int amdgpu_gfx_scratch_get(struct amdgpu_device *adev, uint32_t *reg);
>   void amdgpu_gfx_scratch_free(struct amdgpu_device *adev, uint32_t reg);
>   
> -unsigned amdgpu_gfx_parse_disable_cu(unsigned *mask, unsigned max_se, unsigned max_sh);
> +void
> +amdgpu_gfx_parse_disable_cu(unsigned int *mask,
> +			   unsigned int max_se,
> +			   unsigned int max_sh);
>   
>   #endif