linux-kernel - Re: [PATCHv2 2/5] staging:android:ion: Fix whitespace issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 14:17:18 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     giannis.damigos@...il.com
Cc:     markus.boehme@...lbox.org, arve@...roid.com, riandrews@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 2/5] staging:android:ion: Fix whitespace issues

On Fri, Sep 23, 2016 at 11:05:14AM +0300, giannis.damigos@...il.com wrote:
> From: Yannis Damigos <giannis.damigos@...il.com>
> 
> This patch fixes the following whitespace issues:
> 
> CHECK: Alignment should match open parenthesis
> +int ion_parse_dt_heap_common(struct device_node *heap_node,
> +			struct ion_platform_heap *heap,
> 
> CHECK: Alignment should match open parenthesis
> +	pr_info("%s: id %d type %d name %s align %lx\n", __func__,
> +			heap->id, heap->type, heap->name, heap->align);
> 
> CHECK: Alignment should match open parenthesis
> +int ion_setup_heap_common(struct platform_device *parent,
> +			struct device_node *heap_node,
> 
> CHECK: Alignment should match open parenthesis
> +struct ion_platform_data *ion_parse_dt(struct platform_device *pdev,
> +					struct ion_of_heap *compatible)
> 
> CHECK: Alignment should match open parenthesis
> +	heaps = devm_kzalloc(&pdev->dev,
> +				sizeof(struct
> ion_platform_heap)*num_heaps,

Why is your changelog text line-wrapped?

> 
> CHECK: spaces preferred around that '*' (ctx:VxV)
> +				sizeof(struct
> ion_platform_heap)*num_heaps,

Same here.

And don't mix different types of whitespace cleanup in the same patch
please.

thanks,

greg k-h