linux-kernel - Re: [PATCH v2] ASoC: simple-card: add support for aux devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 17:25:41 -0500
From:   Rob Herring <robh@...nel.org>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Otto Kekäläinen <otto@...avo.fi>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Mengdong Lin <mengdong.lin@...ux.intel.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Andrew Lunn <andrew@...n.ch>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v2] ASoC: simple-card: add support for aux devices

On Fri, Sep 23, 2016 at 10:11:12AM +0300, Nikita Yushchenko wrote:
> This patch makes it possible to use simple-card in setups where separate
> amplifier chip is connected to codec's output.
> 
> Changes from v1:
> - moved example usage from commit message to Documentation/, as
>   suggested by Kuninori Morimoto,
> - fixed typo in example usage.

Ah, one more property to the "simple" card. At what point in adding 
properties is it not simple?

> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> ---
>  .../devicetree/bindings/sound/simple-card.txt      | 37 ++++++++++++++++++++++
>  sound/soc/generic/simple-card.c                    | 34 ++++++++++++++++++++
>  2 files changed, 71 insertions(+)


> 
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt
> index 59d8628..c7a9393 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.txt
> +++ b/Documentation/devicetree/bindings/sound/simple-card.txt
> @@ -22,6 +22,8 @@ Optional properties:
>  					  headphones are attached.
>  - simple-audio-card,mic-det-gpio	: Reference to GPIO that signals when
>  					  a microphone is attached.
> +- simple-audio-card,aux-devs		: List of phandles pointing to auxiliary devices, such
> +					  as amplifiers, to be added to the sound card.

I think the property should be specific as to the type of device. What 
if you have 2 amps? Maybe simple-card can't have 2 outputs. What if you 
have a chain of devices and need to know the order of them?

Rob