linux-kernel - Re: [PATCH] memstick: r592: add function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 24 Sep 2016 10:38:50 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     maximlevitsky@...il.com, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] memstick: r592: add function declaration

On Saturday, September 24, 2016 1:32:26 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/memstick/host/r592.c:50:13: warning: no previous prototype for 'memstick_debug_get_tpc_name' [-Wmissing-prototypes]
> 
> In fact, this function need be declared in a header files.
> 
> So this patch adds function declaration in
> drivers/memstick/host/r592.h.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/memstick/host/r592.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/memstick/host/r592.h b/drivers/memstick/host/r592.h
> index c5726c1..c5d91cd 100644
> --- a/drivers/memstick/host/r592.h
> +++ b/drivers/memstick/host/r592.h
> @@ -172,4 +172,6 @@ struct r592_device {
>  #define dbg_verbose(format, ...)       __dbg(2, format, ## __VA_ARGS__)
>  #define dbg_reg(format, ...)           __dbg(3, format, ## __VA_ARGS__)
>  
> +const char *memstick_debug_get_tpc_name(int tpc);
> +
>  #endif
> 

This looks wrong too. I don't see this function serving any purpose,
despite being exported.

It may be intended to be used by kernel debuggers, but those should
just look up the symbolic value of the enum memstick_tpc
definition instead.

Better just remove the function and the array above it.

	Arnd