linux-kernel - Re: [PATCH 0/3] ethernet: net: bcmgenet: only use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 25 Sep 2016 08:49:50 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Philippe Reynes <tremyfr@...il.com>, jaedon.shin@...il.com,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] ethernet: net: bcmgenet: only use new api
 ethtool_{get|set}_link_ksettings

Le 25/09/2016 à 08:36, Philippe Reynes a écrit :
> Some times ago, a serie of patches were committed :
> - commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device")
> - commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings")
> The first patch add a regression on this driver, so it should be reverted.
> As the second patch depend on the former, it should be reverted too.
> 
> The first patch is buggy because there is a "trick" in this driver.
> The structure phydev is kept in the private data when the interface
> go down, and used when the interface go up to enable the phy before
> the function phy_connect is called.
> 
> I don't have this hardware, neither the datasheet. So I won't
> update the driver to avoid this trick.
> 
> But the real goal of the first serie was to move to the new api
> ethtool_{get|set}_link_ksettings. So I provide a new version of
> the patch without the "cleaning" of driver to use the phydev
> store in the net_device structure.
> 
> Jaedon Shin (1):
>   Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

Please replace Jaedon's patch with mine which contains more background
as to what the problem was and how it gets fixed.

> 
> Philippe Reynes (2):
>   Revert "net: ethernet: bcmgenet: use new api
>     ethtool_{get|set}_link_ksettings"
>   net: ethernet: broadcom: bcmgenet: use new api
>     ethtool_{get|set}_link_ksettings

Can you be consistent in the subject and just use "net: bcmgenet: " as a
prefix here?

> 
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c |   33 ++++++++++++-----------
>  drivers/net/ethernet/broadcom/genet/bcmgenet.h |    1 +
>  drivers/net/ethernet/broadcom/genet/bcmmii.c   |   24 +++++++++--------
>  3 files changed, 31 insertions(+), 27 deletions(-)
> 


-- 
Florian