linux-kernel - Re: [Nouveau] [PATCH] drm/nouveau/secboot/gm20b: Fix return value in case of error

Open Source and information security mailing list archives

Date:   Sun, 25 Sep 2016 18:36:21 +0900
From:   Alexandre Courbot <gnurou@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Ben Skeggs <bskeggs@...hat.com>, David Airlie <airlied@...ux.ie>,
        "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [Nouveau] [PATCH] drm/nouveau/secboot/gm20b: Fix return value in
 case of error

On Sat, Sep 24, 2016 at 6:06 AM, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
> If 'ioremap()' returns 0, 'gm20b_tegra_read_wpr()' will return 0 as well,
> which means success.
> Return -ENOMEM instead

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>

>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Not sure that -ENOMEM is the best value.
> I've taken it because it is often used in such a case.
> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c
> index d5395ebfe8d3..d88db933b3fd 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c
> @@ -142,7 +142,7 @@ gm20b_tegra_read_wpr(struct gm200_secboot *gsb)
>         mc = ioremap(TEGRA_MC_BASE, 0xd00);
>         if (!mc) {
>                 nvkm_error(&sb->subdev, "Cannot map Tegra MC registers\n");
> -               return PTR_ERR(mc);
> +               return -ENOMEM;
>         }
>         gsb->wpr_addr = ioread32_native(mc + MC_SECURITY_CARVEOUT2_BOM_0) |
>               ((u64)ioread32_native(mc + MC_SECURITY_CARVEOUT2_BOM_HI_0) << 32);
> --
> 2.7.4
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives