linux-kernel - Re: [PATCH] staging: fbtft: Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2016 12:05:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        noralf@...nnes.org
Subject: Re: [PATCH] staging: fbtft: Fix checkpatch warning

On Wed, Sep 28, 2016 at 10:59:46AM +0100, Carlos Palminha wrote:
> Improve code readability.

You are doing multiple things in the same patch, and you don't really
tell us what you are doing, or why you are doing it...

Please take a step back, relax, and wait a day before resending a patch
series for these issues.

thanks,

greg k-h