linux-kernel - Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2016 14:09:31 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     shyam saini <mayhs11saini@...il.com>
Cc:     labbott@...hat.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, arve@...roid.com,
        sumit.semwal@...aro.org
Subject: Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL
 comparison and Fixed coding style

On Wed, Sep 28, 2016 at 03:55:32PM +0530, shyam saini wrote:
> Remove the explicit NULL comparison and rewrite in a compact form and
> fixed switch case indentation issue.

If you need "and" in a subject: line for a patch, that's a huge hint
that this needs to be at least 2 patches.

Please only ever do "one type of thing" in a single patch.  And no, that
one thing can not be "fix all coding style issues" :)

Please break this up into multiple patches and resend it.

thanks,

greg k-h