linux-kernel - Re: [PATCH -next] ipmi/bt-bmc: remove redundant return value check of platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2016 19:06:11 -0500
From:   Corey Minyard <tcminyard@...il.com>
To:     Wei Yongjun <weiyj.lk@...il.com>, Corey Minyard <minyard@....org>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ipmi/bt-bmc: remove redundant return value check of
 platform_get_resource()

Thanks, applied.

-corey

On 09/24/2016 07:02 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>   drivers/char/ipmi/bt-bmc.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index de64bf1..b49e613 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -432,11 +432,6 @@ static int bt_bmc_probe(struct platform_device *pdev)
>   	dev_set_drvdata(&pdev->dev, bt_bmc);
>   
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(dev, "Unable to find resources\n");
> -		return -ENXIO;
> -	}
> -
>   	bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
>   	if (IS_ERR(bt_bmc->base))
>   		return PTR_ERR(bt_bmc->base);
>