linux-kernel - Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Oct 2016 17:23:55 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Nadim Almas <nadim.902@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit
 coding style issue

On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Nadim Almas <nadim.902@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index e794056..bc15584 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
>  		 * Rx Oruns. Exar says that an orun will NOT corrupt
>  		 * the FIFO. It will just replace the holding register
>  		 * with this new data byte. So basically just ignore this.
> -		 * Probably we should eventually have an orun stat in our driver...
> +		 * Probably we should eventually have an orun stat in our
> +		 * driver...
>  		 */
>  		ch->ch_err_overrun++;
>  	}

Why did you just fix only one of these warnings in the file?  You aren't
going to send one patch per instance of this warning in this file, are
you?  Please group it all into one.

thanks,

greg k-h