linux-kernel - Re: BUG: scheduling while atomic in f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 03 Oct 2016 22:07:32 +0200
From:   Michal Nazarewicz <mina86@...a86.com>
To:     John Stultz <john.stultz@...aro.org>
Cc:     Chen Yu <chenyu56@...wei.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Biggo Wang <wangbinghui@...ilicon.com>,
        lkml <linux-kernel@...r.kernel.org>, linux-usb@...r.kernel.org,
        Amit Pundir <amit.pundir@...aro.org>,
        Guodong Xu <guodong.xu@...aro.org>
Subject: Re: BUG: scheduling while atomic in f_fs when gadget remove driver

On Mon, Oct 03 2016, John Stultz wrote:
> On Wed, Sep 28, 2016 at 2:38 PM, Michal Nazarewicz <mina86@...a86.com> wrote:
>> On Wed, Sep 28 2016, Michal Nazarewicz wrote:
>>> With that done, the only thing which needs a mutex is
>>> epfile->read_buffer.
>>
>> Perhaps this would do:
>>
>> ---- >8 -------------------------------------------------- -------------
>> From 6416a1065203a39328311f6c58083089efe169aa Mon Sep 17 00:00:00 2001
>> From: Michal Nazarewicz <mina86@...a86.com>
>> Date: Wed, 28 Sep 2016 23:36:56 +0200
>> Subject: [RFC] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> ffs_func_eps_disable is called from atomic context so it cannot sleep
>> thus cannot grab a mutex.  Change the handling of epfile->read_buffer
>> to use non-sleeping synchronisation method.
>>
>> Reported-by: Chen Yu <chenyu56@...wei.com>
>> Signed-off-by: Michał Nazarewicz <mina86@...a86.com>
>> Fixes: 9353afbbfa7b ("buffer data from ‘oversized’ OUT requests")
>
> So the patch here seems to be in some odd encoding?

O_o
It’s UTF-8.

> Can you resend it using git-send-email or in some way other then
> embedding it inline here? Maybe just point me to a git tree that has
> it?

	https://github.com/mina86/linux.git f-fs-fix

Regardless, I’ll prepare a proper patchset within a few days.  Maybe
even now.

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»