linux-kernel - Re: [PATCH] cxgb4: unexport cxgb4_dcb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 03 Oct 2016 01:33:41 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     hariprasad@...lsio.com, rahul.lakkireddy@...lsio.com,
        nab@...ux-iscsi.org, varun@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxgb4: unexport cxgb4_dcb_enabled

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 30 Sep 2016 18:15:33 +0200

> A recent cleanup marked cxgb4_dcb_enabled as 'static', which is correct, but this ignored
> how the symbol is also exported. In addition, the export can be compiled out when modules
> are disabled, causing a harmless compiler warning in configurations for which it is not
> used at all:
> 
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:282:12: error: 'cxgb4_dcb_enabled' defined but not used [-Werror=unused-function]
> 
> This removes the export and moves the function into the correct #ifdef so we only build
> it when there are users.
> 
> Fixes: 50935857f878 ("cxgb4: mark symbols static where possible")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.