linux-kernel - Re: [PATCH 6/6] mISDN: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 24 Sep 2016 10:42:14 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     isdn@...ux-pingi.de, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xie.baoyou@....com.cn
Subject: Re: [PATCH 6/6] mISDN: remove unused function

On Saturday, September 24, 2016 1:28:02 PM CEST Baoyou Xie wrote:
> diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
> index f6ab6027..2519510 100644
> --- a/drivers/isdn/mISDN/layer2.c
> +++ b/drivers/isdn/mISDN/layer2.c
> @@ -459,15 +459,6 @@ IsDISC(u_char *data)
>         return (data[0] & 0xef) == DISC;
>  }
>  
> -inline int
> -IsRR(u_char *data, struct layer2 *l2)
> -{
> -       if (test_bit(FLG_MOD128, &l2->flag))
> -               return data[0] == RR;
> -       else
> -               return (data[0] & 0xf) == 1;
> -}
> -
>  static inline int
>  IsSFrame(u_char *data, struct layer2 *l2)
>  {
> -- 
> 

This is not wrong, but it might be nicer to just
make this one as 'static inline' as well like the other
ones for consistency.

Note that static inline functions don't cause a warning
when they are unused.

	Arnd