linux-kernel - Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Oct 2016 10:21:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Don Zickus <dzickus@...hat.com>, Joe Mario <jmario@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key

Em Wed, Oct 05, 2016 at 02:38:54PM +0200, Jiri Olsa escreveu:
> On Wed, Oct 05, 2016 at 07:50:36AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Oct 05, 2016 at 07:45:17AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, Oct 05, 2016 at 12:46:12AM +0200, Jiri Olsa escreveu:
> > > > On Tue, Oct 04, 2016 at 01:50:12PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > Em Thu, Sep 22, 2016 at 05:36:48PM +0200, Jiri Olsa escreveu:
> > > > > > Adding dcacheline dimension key support. It
> > > > > > displays cacheline address as hex number.
> > > > > > 
> > > > > > Using c2c wrapper to standard 'dcacheline' object
> > > > > > to defined own header and simple (just address)
> > > > > > cacheline output.
> > > > > 
> > > > > So, at this point I move from:
> > > > > 
> > > > >   # perf c2c report
> > > > >    Error: Invalid --fields key: `dcacheline'
> > > > >   #
> > > > > 
> > > > > To:
> > > > > 
> > > > >   [root@...et ~]# perf c2c report
> > > > >   Error: Unknown --fields key: `offset'
> > > > >   Segmentation fault (core dumped)
> > > > >   [root@...et ~]#
> > > > 
> > > > oops, attached patch should fix that, but I needed to change
> > > > following patches:
> > 
> > Now we're at:
> > 
> > [root@...et ~]# perf c2c report
> >   Error: Unknown --fields key: `offset'
> > 0x50cbc0 [0x8]: failed to process type: 68
> > failed to process sample
> > [root@...et ~]#
> 
> well thats because we implicitly sort by offset but
> there's no 'offset' ket support yet in your branch
> 
> basically the perf report does not display/do anything
> till following patch:
> 
>   perf c2c report: Add stdio output support

ok, but till then, it better not segfault :-) The message for that type
68 also probably should go to a more verbose level of debugging.

- Arnaldo
 
> I made sure now that the perf c2c report wont crash
> till that patch..

Ok!

> 
> jirka