linux-kernel - Re: [PATCH] rcu: Reword help of RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Oct 2016 07:03:07 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Nikolay Borisov <kernel@...p.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: Reword help of RCU_TRACE option

On Wed, Oct 05, 2016 at 10:06:21AM +0300, Nikolay Borisov wrote:
> Explicitly state that enabling RCU_TRACE enables more
> tracepoints and not just "additional tracing".
> 
> Signed-off-by: Nikolay Borisov <kernel@...p.com>
> ---
> 
> Hello Paul, 
> 
> Following our latest conversation re. enabling RCU tracing
> I had to actually go and look into the code to see which 
> option enables the additional tracepoints. I wasn't sure
> while reading the help of TRACE_RCU. So here is a patch
> which explicitly states that this enables additional 
> tracepoints. 
> 
> Apply it if you deem necessary it might be just me that 
> thinks the description is not verbose enough. 
> 
>  lib/Kconfig.debug | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index cab7405f48d2..f8c3468ec7ef 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1429,8 +1429,8 @@ config RCU_TRACE
>  	depends on DEBUG_KERNEL
>  	select TRACE_CLOCK
>  	help
> -	  This option provides tracing in RCU which presents stats
> -	  in debugfs for debugging RCU implementation.
> +	  This option enables additional tracepoints in RCU which present
> +	  stats in debugfs for debugging RCU implementation.

How about something like this?

	This option provides tracing in RCU which presents stats
	in debugfs for debugging RCU implementation.  It also enables
	additional tracepoints for ftrace-style event tracing.

							Thanx, Paul

> 
>  	  Say Y here if you want to enable RCU tracing
>  	  Say N if you are unsure.
> -- 
> 2.5.0
>