linux-kernel - Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2016 13:52:15 +0530
From:   Nadim Almas <nadim.902@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Lidza Louina <lidza.louina@...il.com>, markh@...pro.net,
        devel@...verdev.osuosl.org, driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit
 coding style issue

May be it is not looking better than yours but it removed 6 warning of
the file which is shown by running "perl scripts/checkpatch.pl -f
drivers/staging/dgnc/* | less" commend

On Thu, Oct 6, 2016 at 10:51 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
>> Fixed coding style issue
>>
>> Signed-off-by: Nadim Almas <nadim.902@...il.com>
>> ---
>>  drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
>>  1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
>> index abddd48..65994e3 100644
>> --- a/drivers/staging/dgnc/dgnc_neo.h
>> +++ b/drivers/staging/dgnc/dgnc_neo.h
>> @@ -30,7 +30,8 @@
>>  struct neo_uart_struct {
>>       u8 txrx;                /* WR  RHR/THR - Holding Reg */
>>       u8 ier;         /* WR  IER - Interrupt Enable Reg */
>> -     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
>> +     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
>> +                                                                     /*Reg */
>
> Does that really look better now than it did before?
>
> I don't think so :(
>
> sorry,
>
> greg k-h