linux-kernel - Re: [REGRESSION] "dwc2: gadget: fix TX FIFO size and address initialization" breaks "adb logcat" on hikey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2016 11:24:34 -0700
From:   John Youn <John.Youn@...opsys.com>
To:     John Stultz <john.stultz@...aro.org>,
        Robert Baldyga <r.baldyga@...sung.com>,
        John Youn <John.Youn@...opsys.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
CC:     lkml <linux-kernel@...r.kernel.org>,
        Amit Pundir <amit.pundir@...aro.org>,
        Guodong Xu <guodong.xu@...aro.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [REGRESSION] "dwc2: gadget: fix TX FIFO size and address
 initialization" breaks "adb logcat" on hikey

On 10/5/2016 11:33 PM, John Stultz wrote:
> Hey folks,
>    So I've run into some trouble that I've narrowed down to commit
> aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address
> initialization").
> 
> After booting up android on HiKey, if I run "adb logcat", I get about
> a page of logs and then I get disconnected.  On the device side, I see
> the following in dmesg:
> 
> [   35.652076] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep
> ffffffc078a4c218 ep1in, 0)
> [   35.660334] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep
> ffffffc078a4c018 ep1out, 0)
> 
> After which if I stop adbd I see:
> 
> [   99.471363] dwc2 f72c0000.usb: dwc2_hsotg_ep_stop_xfr: timeout flushing fifos
> 
> and if I then restart adbd on the device it will sometimes work, but not always.
> 
> Reverting
> ba48eab8866c ("usb: dwc2: gadget: change variable name to more meaningful")
> and
> aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address initialization")
> 
> makes things work again.
> 
> Any thoughts as to what might be going wrong here? I'd be happy to
> help debug things.
> 
> thanks
> -john
> 


Hi John,

Yup. I've already submitted patches to revert these last week, to be
applied sometime during the 4.9-rc cycle. We're working on a more
robust fix for the FIFOs too.

Regards,
John