linux-kernel - Re: [PATCH V3] staging: ks7010: use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 09 Oct 2016 22:56:02 -0700
From:   Joe Perches <joe@...ches.com>
To:     Sabitha George <sabitha.george@...il.com>,
        gregkh@...uxfoundation.org, wsa+renesas@...g-engineering.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] staging: ks7010: use netdev_* instead of printk()

On Mon, 2016-10-10 at 11:14 +0530, Sabitha George wrote:
> 1. Fixes checkpatch warning on printk usage in ks_hostif.c
> 2. Dropped "ks_wlan" prefix from the messages
> 3. Removed the "Memory squeeze,dropping packet" messages
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -549,7 +545,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
>  		dev->dev_addr[5] = priv->eth_addr[5];
>  		dev->dev_addr[6] = 0x00;
>  		dev->dev_addr[7] = 0x00;
> -		printk(KERN_INFO "ks_wlan: MAC ADDRESS = %pM\n", priv->eth_addr);
> +		netdev_info(dev, "MAC ADDRESS = %pM\n",
> +			    priv->eth_addr);

Do please use all 80 columns where possible.

		netdev_info(dev, "MAC ADDRESS = %pM\n", priv->eth_addr);