linux-kernel - [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2016 15:59:55 +0200
From:   Ralf Ramsauer <ralf@...ses-pyramidenbau.de>
To:     Mark Brown <broonie@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Linux SPI <linux-spi@...r.kernel.org>,
        Linux I2C <linux-i2c@...r.kernel.org>
Cc:     Ralf Ramsauer <ralf@...ses-pyramidenbau.de>,
        "linux-kernel @ vger . kernel . org" <linux-kernel@...r.kernel.org>,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Subject: [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation

Hi,

this one fixes initialisation of I2C/SPI nodes.  Upon failure during
intialisation, nodes were erroneously populated and never unmarked.

This lead to the problem that re-loaded drivers will never probe those devices
again and can easily be fixed by clearing the OF_POPULATE flag when the node
doesn't successfully initialise.

For the discussion of v1, see
https://lkml.org/lkml/2016/10/14/483

  Ralf

changes since v1:
  - also fix I2C core driver
  - keep the atomic test-and-set, as Geert suggested

Ralf Ramsauer (2):
  spi: mark device nodes only in case of successful instantiation
  i2c: mark device nodes only in case of successful instantiation

 drivers/i2c/i2c-core.c | 11 ++++++++++-
 drivers/spi/spi.c      |  5 ++++-
 2 files changed, 14 insertions(+), 2 deletions(-)

-- 
2.10.1