linux-kernel - Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2016 09:56:11 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jerome Forissier <jerome.forissier@...aro.org>,
        Andy Whitcroft <apw@...onical.com>,
        linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] checkpatch: don't try to get maintained status when
 --no-tree is given

On Mon, 2016-10-17 at 17:55 +0200, Jerome Forissier wrote:
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.

Thanks Jerome.

> Signed-off-by: Jerome Forissier <jerome.forissier@...aro.org>

Acked-by: Joe Perches <joe@...ches.com>

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..aa694bc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
>  sub is_maintained_obsolete {
>  	my ($filename) = @_;
>  
> -	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> +	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>  
>  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;