linux-kernel - [PATCH] net, skbuff: Get rid of unused skb_propagate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2016 14:32:22 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Michal Hocko <mhocko@...e.com>
Subject: [PATCH] net, skbuff: Get rid of unused skb_propagate_pfmemalloc

From: Michal Hocko <mhocko@...e.com>

It seems that skb_propagate_pfmemalloc has never had a user since it was
introduced by 0614002bb5f7 ("netvm: propagate page->pfmemalloc from
skb_alloc_page to skb"). Remove it.

Signed-off-by: Michal Hocko <mhocko@...e.com>
---
Hi,
I've posted this trivial cleanup quite some time ago but it seemed to
fall through cracks. I've found it again while cleaning up my local repo.
Is there any interest in it or should I just drop it and do not care?

 include/linux/skbuff.h | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 601258f6e621..641843a786d8 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2535,18 +2535,6 @@ static inline struct page *dev_alloc_page(void)
 }
 
 /**
- *	skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page
- *	@page: The page that was allocated from skb_alloc_page
- *	@skb: The skb that may need pfmemalloc set
- */
-static inline void skb_propagate_pfmemalloc(struct page *page,
-					     struct sk_buff *skb)
-{
-	if (page_is_pfmemalloc(page))
-		skb->pfmemalloc = true;
-}
-
-/**
  * skb_frag_page - retrieve the page referred to by a paged fragment
  * @frag: the paged fragment
  *
-- 
2.9.3