linux-kernel - Re: [PATCH v3 2/2] Add support for Omnivision OV5647

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2016 13:15:07 +0200
From:   Pavel Machek <pavel@....cz>
To:     Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>
Cc:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com, mchehab@...nel.org, davem@...emloft.net,
        geert@...ux-m68k.org, akpm@...ux-foundation.org,
        kvalo@...eaurora.org, linux@...ck-us.net, hverkuil@...all.nl,
        lars@...afoo.de, robert.jarzmik@...e.fr, slongerbeam@...il.com,
        dheitmueller@...nellabs.com, pali.rohar@...il.com,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v3 2/2] Add support for Omnivision OV5647

Hi!

> >> +struct regval_list {
> >> +	uint16_t addr;
> >> +	uint8_t data;
> >> +};
> > u8/u16?
> 
> This sensor uses 16 bits for addresses and 8 for data, so I think it makes sense
> to keep it this way.

Yes, you can do it. But please use u8/u16 types (also elsewhere in the
driver), they are more common in ther kernel.

> Thanks for the feedback. I agree with most of your suggestions, and I commented
> with the one I didn't agree.

You are welcome,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)