linux-kernel - Re: [PATCH 29/37] staging:r8188eu: take out stripping of iv and icv space from wlanhdr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2016 12:11:45 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ivan Safonov <insafonov@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Geliang Tang <geliangtang@....com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 29/37] staging:r8188eu: take out stripping of iv and icv
 space from wlanhdr_to_ethhdr function

On Wed, Oct 19, 2016 at 10:07:57PM +0700, Ivan Safonov wrote:
> @@ -1733,6 +1729,13 @@ static int recv_indicatepkts_in_order(struct adapter *padapter, struct recv_reor
>  	return bPktInBuf;
>  }
>  
> +void strip_iv_icv(struct sk_buff *skb, uint header_len,
> +		  uint iv_len, uint icv_len) {

Curly braces go down a line.

> +	memmove(skb->data + iv_len, skb->data, header_len);
> +	skb_pull(skb, iv_len);
> +	skb_trim(skb, skb->len - icv_len);
> +}

regards,
dan carpenter