linux-kernel - Re: [PATCH] staging: wilc1000: Remove unused function wilc_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2016 11:17:59 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Binoy Jayan <binoy.jayan@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Aditya Shankar <aditya.shankar@...rochip.com>,
        Ganesh Krishna <ganesh.krishna@...rochip.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wilc1000: Remove unused function wilc_lock_timeout

On Thursday, October 20, 2016 2:24:32 PM CEST Binoy Jayan wrote:
> Semaphore are going away in the future, so remove the unused function
> wilc_lock_timeout which calls a semaphore api but has no users.
> 
> Signed-off-by: Binoy Jayan <binoy.jayan@...aro.org>
> ---
> 
> They following is a patch which removes semaphores from wilc1000.
> Its part of a bigger effort to eliminate all semaphores
> from the linux kernel.

Good catch!

>  drivers/staging/wilc1000/linux_wlan.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index 6370a5e..470d59f 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -218,17 +218,6 @@ static void deinit_irq(struct net_device *dev)
>         }
>  }
>  
> -int wilc_lock_timeout(struct wilc *nic, void *vp, u32 timeout)
> -{
> -       /* FIXME: replace with mutex_lock or wait_for_completion */
> -       int error = -1;
> -
> -       if (vp)
> -               error = down_timeout(vp,
> -                                    msecs_to_jiffies(timeout));
> -       return error;
> -}

You need to remove the prototype from wilc_wfi_netdevice.h
as well. Once you do that, please add

Reviewed-by: Arnd Bergmann <arnd@...db.de>