linux-kernel - Re: [PATCH v1 0/6] PMC Core driver new features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2016 08:20:11 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
Cc:     platform-driver-x86@...r.kernel.org,
        andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/6] PMC Core driver new features

On Fri, Oct 07, 2016 at 04:01:11PM +0530, Rajneesh Bhardwaj wrote:
> This patch series adds few new features to the Intel PMC Core driver
> applicable for Skylake & Kabylake SoCs with Sunrise Point LP PCH. These new
> features enhance the low power debug capabilities on Intel platforms. These
> debug features can be used for platform power optimization. Please refer to
> the commit messages of the individual patches and the 7th Generation Intel
> Processor Families I/O for U/Y Platforms datasheet for more documentation.
> 
> New debug features:
> 
> 1. PCH IP Power Gating Status
> 2. ModPhy Core Lanes Power Gating Status
> 3. ModPhy PLL (Common Lanes) clock Gating Status
> 4. LTR Ignore feature
> 5. Support for Kabylake SoC
> 
> Rajneesh Bhardwaj (6):
>   intel_pmc_core: Fix PWRMBASE mask and mmio reg len
>   intel_pmc_core: Add PCH IP Power Gating Status
>   intel_pmc_core: ModPhy core lanes pg status
>   intel_pmc_core: Add MPHY PLL clock gating status
>   intel_pmc_core: Add LTR IGNORE debug feature
>   intel_pmc_core: Add KBL CPUID support
> 
>  drivers/platform/x86/intel_pmc_core.c | 386 +++++++++++++++++++++++++++++++++-
>  drivers/platform/x86/intel_pmc_core.h | 110 +++++++++-
>  2 files changed, 490 insertions(+), 6 deletions(-)

Hi Rajneesh,

I've reviewed and found no major issues. This series has been queued to testing
for 4.10.

Andy, this is a significant patch series, and I'd like it to have another public
review before. Can you please review these 6 patches and provide your
reviewed-by?

drivers/platform/x86/intel_pmc_core.c:172:12: warning: ‘pmc_core_dev_state_get’ defined but not used [-Wunused-function]
 static int pmc_core_dev_state_get(void *data, u64 *val)

This is using a minimal allnoconfig with the pdx86 configs enabled. Config
attached. Can you have a look please?

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center

View attachment ".config" of type "text/plain" (43178 bytes)