linux-kernel - Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2016 10:10:39 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, Jassi Brar <jassisinghbrar@...il.com>
Subject: Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload

On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
> alias:          of:N*T*Cmailbox-testC*
> alias:          of:N*T*Cmailbox-test
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 
>  drivers/mailbox/mailbox-test.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
> index 9ca96e9db6bf..deb9c61aebb4 100644
> --- a/drivers/mailbox/mailbox-test.c
> +++ b/drivers/mailbox/mailbox-test.c
> @@ -357,6 +357,7 @@ static const struct of_device_id mbox_test_match[] = {
>  	{ .compatible = "mailbox-test" },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, mbox_test_match);
>  
>  static struct platform_driver mbox_test_driver = {
>  	.driver = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog