linux-kernel - Re: [PATCH] drm/arm: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2016 18:50:14 +0100
From:   liviu.dudau@....com
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>, brian.starkey@....com,
        malidp@...s.arm.com, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn, han.fei@....com.cn, tang.qiang007@....com.cn
Subject: Re: [PATCH] drm/arm: mark symbols static where possible

On Mon, Oct 24, 2016 at 12:18:37PM +0200, Arnd Bergmann wrote:
> On Saturday, October 22, 2016 5:13:01 PM CEST Baoyou Xie wrote:
> > We get 2 warnings when building kernel with W=1:
> > drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes]
> > drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes]
> > 
> > In fact, both functions are only used in the file in which they are
> > declared and don't need a declaration, but can be made static.
> > So this patch marks these functions with 'static'.
> > 
> > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> > ---
> ...
> > @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane)
> >  	return &state->base;
> >  }
> >  
> > -void malidp_destroy_plane_state(struct drm_plane *plane,
> > +static void malidp_destroy_plane_state(struct drm_plane *plane,
> >  				struct drm_plane_state *state)
> >  {
> >  	struct malidp_plane_state *m_state = to_malidp_plane_state(state);
> > 
> 
> The change looks correct, but I notice that the two lines of the
> declaration are no longer aligned.
> 
> The file follows the normal style of aligning the argument list
> in the second line to line up with the opening '(', so please keep
> it that way.
> 
> 	Arnd
> 

Fixed it locally and pushed it into my public repo @ git://linux-arm.org/linux-ld.git for-upstream/mali-dp

I will send it to David Airlie as a pull request together with the other patches/cleanups.

Many thanks,
Liviu


-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯