linux-kernel - Re: [PATCH v3 1/9] mtd: spi-nor: improve macronix_quad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2016 10:52:01 +0200
From:   Cyrille Pitchen <cyrille.pitchen@...el.com>
To:     Marek Vasut <marex@...x.de>, <computersforpeace@...il.com>,
        <linux-mtd@...ts.infradead.org>
CC:     <nicolas.ferre@...el.com>, <boris.brezillon@...e-electrons.com>,
        <richard@....at>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/9] mtd: spi-nor: improve macronix_quad_enable()

Hi Marek,

Le 25/10/2016 à 00:00, Marek Vasut a écrit :
> On 10/24/2016 06:34 PM, Cyrille Pitchen wrote:
>> The patch checks whether the Quad Enable bit is already set in the Status
>> Register. If so, the function exits immediately with a successful return
>> code. Otherwise, a message is now printed telling we're setting the
>> non-volatile bit.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>
>> Reviewed-by: Jagan Teki <jagan@...nedev.com>
>> ---
>>  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index d0fc165d7d66..5c87b2d99507 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -1211,6 +1211,11 @@ static int macronix_quad_enable(struct spi_nor *nor)
>>  	val = read_sr(nor);
>>  	if (val < 0)
>>  		return val;
>> +	if (val & SR_QUAD_EN_MX)
>> +		return 0;
>> +
>> +	/* Update the Quad Enable bit. */
>> +	dev_info(nor->dev, "setting Macronix Quad Enable (non-volatile) bit\n");
> 
> Should probably be dev_dbg(), since this is just churn in the kernel
> log. The user doesn't care and the developer can just up the debug level
> or add his own printk .
>

The Quad Enable bit is non-volatile so this trace should be printed only once
but I'm perfectly fine with using dev_dbg(). I'll change it in the next version.

Best regards,

Cyrille
 
>>  	write_enable(nor);
>>  
>>  	write_sr(nor, val | SR_QUAD_EN_MX);
>>
> 
>