linux-kernel - Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2016 18:31:21 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lars-Peter Clausen <lars@...afoo.de>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Alison Schofield <amsfield22@...il.com>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable
 in error case

On 25/10/16 18:00, Lars-Peter Clausen wrote:
> On 10/25/2016 06:57 PM, Jonathan Cameron wrote:
>> On 24/10/16 16:22, Arnd Bergmann wrote:
>>> The ad5933_i2c_read function returns an error code to indicate
>>> whether it could read data or not. However ad5933_work() ignores
>>> this return code and just accesses the data unconditionally,
>>> which gets detected by gcc as a possible bug:
>>>
>>> drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'ad5933_work':
>>> drivers/staging/iio/impedance-analyzer/ad5933.c:649:16: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> This adds minimal error handling so we only evaluate the
>>> data if it was correctly read.
>>>
>>> Link: https://patchwork.kernel.org/patch/8110281/
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Looks good to me.
>>
>> Lars?
>>
> 
> Looks good, thanks.
> 
> Acked-by: Lars-Peter Clausen <lars@...afoo.de>
Applied to the fixes-togreg branch of iio.git and marked for stable.

thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>