linux-kernel - Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2016 10:34:11 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Peter Ujfalusi <peter.ujfalusi@...com>,
        Benoît Cousson <bcousson@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Pawel Moll <pawel.moll@....com>,
        Mark Rutland <mark.rutland@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Kumar Gala <galak@...eaurora.org>,
        Russell King <linux@....linux.org.uk>,
        Russell King <linux@...linux.org.uk>,
        devicetree@...r.kernel.org, letux-kernel@...nphoenux.org,
        linux-kernel@...r.kernel.org, ldewangan@...dia.com,
        kernel@...a-handheld.com, marek@...delico.com,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset
 jack detection

* H. Nikolaus Schaller <hns@...delico.com> [161025 10:20]:
> 
> > Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@...com>:
> > 
> > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
> >> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> >> ---
> >> arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> index b04adee..91456b4 100644
> >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> @@ -124,6 +124,7 @@
> >> 		compatible = "ti,abe-twl6040";
> >> 		ti,model = "omap5-uevm";
> >> 
> >> +		ti,jack_detection;
> > 
> > ti,jack-detection
> 
> Hm. Looks as if we have found another bug:
> which one is correct?
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289
> 
> Should I add another patch?

We have parts of omap-abe-twl6040.txt, the driver and omap4-sdp.dts all
using ti,jack-detection. So omap-abe-twl6040.txt is wrong for the use
of ti,jack_detection.

Regards,

Tony