linux-kernel - Re: [PATCH] powerpc: process.c: fix Kconfig typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2016 12:43:12 +0200
From:   Valentin Rothberg <valentinrothberg@...il.com>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Cyril Bur <cyrilbur@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] powerpc: process.c: fix Kconfig typo

On Wed, Oct 26, 2016 at 12:40 PM, Michael Ellerman <mpe@...erman.id.au> wrote:
> Valentin Rothberg <valentinrothberg@...il.com> writes:
>
>> On Wed, Oct 26, 2016 at 7:52 AM, Michael Ellerman <mpe@...erman.id.au> wrote:
>>> Cyril Bur <cyrilbur@...il.com> writes:
>>>
>>>> On Wed, 2016-10-05 at 07:57 +0200, Valentin Rothberg wrote:
>>>>> s/ALIVEC/ALTIVEC/
>>>>>
>>>>
>>>> Oops, nice catch
>>>>
>>>>> Signed-off-by: Valentin Rothberg <valentinrothberg@...il.com>
>>>>
>>>> Reviewed-by: Cyril Bur <cyrilbur@...il.com>
>>>
>>> How did we not notice? Sounds like we need a new selftest.
>>>
>>> Looks like this should have:
>>>
>>> Fixes: dc16b553c949 ("powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use")
>>>
>>>
>>> And I guess I need to start running checkkconfigsymbols.py on every
>>> commit.
>>
>> Happy to find a new user :-)  You can also run the script on a range
>> of commits via '--diff commitA..commitB', which can safe some time.
>
> Yeah I just discovered that, very useful.
>
> But my instinct was to do:
>
> $ ./scripts/checkkconfigsymbols.py --diff HEAD^^^..HEAD
>
> Which didn't work, the regexp is a bit tight, fixed by:
>
> diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
> index a32e4da4c117..3820f00b066a 100755
> --- a/scripts/checkkconfigsymbols.py
> +++ b/scripts/checkkconfigsymbols.py
> @@ -88,7 +88,7 @@ def parse_options():
>      if args.commit and args.diff:
>          sys.exit("Please specify only one option at once.")
>
> -    if args.diff and not re.match(r"^[\w\-\.]+\.\.[\w\-\.]+$", args.diff):
> +    if args.diff and not re.match(r"^[\w\-\.\^]+\.\.[\w\-\.\^]+$", args.diff):
>          sys.exit("Please specify valid input in the following format: "
>                   "\'commit1..commit2\'")

Looks great.  If you agree, I'll pick this up and send the patch to
Greg (who takes patches for this script)?

Thanks,
 Valentin