linux-kernel - RE: UBIFS LEB properties tree with odd addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2016 12:11:23 +0000
From:   Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>
To:     Richard Weinberger <richard@....at>,
        Christoph Hellwig <hch@...radead.org>
CC:     "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "dedekind1@...il.com" <dedekind1@...il.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "Punnaiah Choudary Kalluri" <punnaia@...inx.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>
Subject: RE: UBIFS LEB properties tree with odd addresses

Hi Richard,

-----Original Message-----
From: Richard Weinberger [mailto:richard@....at] 
Sent: Wednesday, October 26, 2016 2:44 AM
To: Naga Sureshkumar Relli <nagasure@...inx.com>; Christoph Hellwig <hch@...radead.org>
Cc: dwmw2@...radead.org; computersforpeace@...il.com; dedekind1@...il.com; adrian.hunter@...el.com; michal.simek@...inx.com; Punnaiah Choudary Kalluri <punnaia@...inx.com>; linux-mtd@...ts.infradead.org; linux-kernel@...r.kernel.org; Boris Brezillon <boris.brezillon@...e-electrons.com>
Subject: Re: UBIFS LEB properties tree with odd addresses

Naga Sureshkumar Relli,
>     Even bytes i.e. 0, 2, 4,... are transmitted on Lower Data Bus
>     Odd bytes i.e. 1, 3, 5,.. are transmitted on Upper Data Bus.

> But these details are hidden from UBI?

Yes, Our controller driver will take care of these byte striping.

> So for temporary hack we did the following change In fs/ubifs/lpt.c In 
> do_calc_lpt_geom(), added the following
> +       if (c->pnode_sz % 2)
> +               c->pnode_sz += 1; 
> +       if (c->ltab_sz % 2)
> +               c->ltab_sz += 1;
> 
> Please kindly suggest, I need your inputs, changing the pnode_sz and ltab_sz to even in lpt.c, will it impact on any others?

> Hmm, the calculations in lpt.c use basic properties of the MTD (number of blocks, etc...).
> Can you please double check which property causes the failure and also verify whether the MTD driver provides correct properties. i.e. page sizes, block size, number of blocks, ...

Yes, only pnode_sz and ltab_sz are odd values

And MTD info, here are my logs
In Single Flash mode:
Mtd->erasesize = 64KiB
Mtd->size = 64MiB
Mtd->numeraseregions = 0
Nor->pagesize = 256

In Dual parallel mode:
Mtd->erasesize = 128KiB
Mtd->size = 128MiB
Mtd->numeraseregions = 0
Nor->pagesize = 512

Thanks,
Naga Sureshkumar Relli