linux-kernel - RE: [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2016 05:28:52 +0000
From:   Sriram Dash <sriram.dash@....com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Suresh Gupta <suresh.gupta@....com>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "pku.leo@...il.com" <pku.leo@...il.com>
Subject: RE: [PATCH 3/3] usb: dwc3: host: Do not use
 dma_coerce_mask_and_coherent

>From: Arnd Bergmann [mailto:arnd@...db.de]
>On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote:
>> Do not use dma_coerce_mask_and_coherent for hcd.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
>The patch is good, but please follow the usual rules for submitting someone else's
>patch:
>
>- As the first line, have "From: Arnd Bergmann <arnd@...db.de>".
>  "git format-patch" adds this automatically if you pass that
>  address as the "--author" argument to "git commit".
>
>- Add you "Signed-off-by" line at below mine (or any other lines)
>
>I would also suggest a more elaborate changelog text, the free-form text should
>explain why something is done, rather than repeat the subject:
>
>| The dma mask is correctly set up by the DT probe function, no need to
>| override it any more.
>

Ok Arnd. I will take care for the next version.

>	Arnd