linux-kernel - RE: [PATCH] ASoC: da7219: Connect output enable register to DAIOUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2016 09:36:04 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Stephen Barber <smbarber@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
CC:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hsin-Yu Chao <hychao@...omium.org>,
        "Dylan Reid" <dgreid@...omium.org>
Subject: RE: [PATCH] ASoC: da7219: Connect output enable register to DAIOUT

On 28 October 2016 02:02, Steve Barber wrote:

> da7219 output (for headset capture) should be set to high-impedance when
> not in use, since it will otherwise interfere with output from other
> codecs attached to the same DAI.
> 
> Signed-off-by: Stephen Barber <smbarber@...omium.org>
> ---
>  sound/soc/codecs/da7219.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index 2610fc5..9960162 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -959,7 +959,8 @@ static const struct snd_soc_dapm_widget
> da7219_dapm_widgets[] = {
>  			    SND_SOC_DAPM_PRE_PMU |
> SND_SOC_DAPM_POST_PMD),
> 
>  	/* DAI */
> -	SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, SND_SOC_NOPM, 0, 0),
> +	SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0,
> DA7219_DAI_TDM_CTRL,
> +			     DA7219_DAI_OE_SHIFT, DA7219_NO_INVERT),
>  	SND_SOC_DAPM_AIF_IN("DAIIN", "Playback", 0, SND_SOC_NOPM, 0, 0),
> 
>  	/* Output Muxes */
> --
> 2.8.0.rc3.226.g39d4020

Acked-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>