linux-kernel - Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2016 14:18:43 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Thierry Reding <thierry.reding@...il.com>
CC:     <linux-kernel@...r.kernel.org>,
        Gustaf Lindström <gl@...ntia.se>,
        David Airlie <airlied@...ux.ie>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        <dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp
 LQ150X1LG11 panels

On 2016-10-19 14:31, Thierry Reding wrote:
> On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote:
>> On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote:
>>> From: Gustaf Lindström <gl@...ntia.se>
>>>
>>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
>>>
>>> The simple-panel driver is used to get support for essential
>>> functionality of the panel.
>>>
>>> Signed-off-by: Gustaf Lindström <gl@...ntia.se>
>>> Signed-off-by: Peter Rosin <peda@...ntia.se>
>>> ---
>>>  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
>>>  1 file changed, 27 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>>> index 85143d1b9b31..58cfe0a7a9d6 100644
>>> --- a/drivers/gpu/drm/panel/panel-simple.c
>>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>>> @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = {
>>>  	},
>>>  };
>>>  
>>> +static const struct drm_display_mode sharp_lq150x1lg11_mode = {
>>> +	.clock = 71100,
>>> +	.hdisplay = 1024,
>>> +	.hsync_start = 1024 + 168,
>>> +	.hsync_end = 1024 + 168 + 64,
>>> +	.htotal = 1024 + 168 + 64 + 88,
>>> +	.vdisplay = 768,
>>> +	.vsync_start = 768 + 37,
>>> +	.vsync_end = 768 + 37 + 2,
>>> +	.vtotal = 768 + 37 + 2 + 8,
>>> +	.vrefresh = 60,
>>> +};
>>> +
>>> +static const struct panel_desc sharp_lq150x1lg11 = {
>>> +	.modes = &sharp_lq150x1lg11_mode,
>>> +	.num_modes = 1,
>>> +	.bpc = 8,
>>> +	.size = {
>>> +		.width = 304,
>>> +		.height = 228,
>>> +	},
>>> +	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
>>
>> This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for
>> RGB565 panels.
> 
> Are you actually using the .bpc field in your driver? If yes, can you
> please test if things work correctly if you set it to 6? If it's unused
> I'm leaning towards just applying this with .bpc set to 6 and hope for
> the best (and fix it if somebody finds that it's broken).
> 
> So no need to resend, just let me know what you think.

Sorry for the delay, but I just tested .bpc = 6 and it was ok too. It
doesn't seem to matter for us, so do as you like.

Cheers,
Peter