linux-kernel - Re: [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2016 13:04:33 +0900
From:   Milo Kim <woogyom.kim@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     bcousson@...libre.com, Tony Lindgren <tony@...mide.com>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number

On 10/26/2016 10:56 PM, Lee Jones wrote:
>> diff --git a/include/linux/mfd/tps65217.h b/include/linux/mfd/tps65217.h
>> > index 4ccda89..75a3a5f 100644
>> > --- a/include/linux/mfd/tps65217.h
>> > +++ b/include/linux/mfd/tps65217.h
>> > @@ -235,9 +235,9 @@ struct tps65217_bl_pdata {
>> >  };
>> >
>> >  enum tps65217_irq_type {
>> > -	TPS65217_IRQ_PB,
>> > -	TPS65217_IRQ_AC,
>> >  	TPS65217_IRQ_USB,
>> > +	TPS65217_IRQ_AC,
>> > +	TPS65217_IRQ_PB,
>> >  	TPS65217_NUM_IRQ
>> >  };
> This is why using enum for these types of assignments is sometimes
> dangerous.  It's probably best to be explicit.

I agree with you. Let me fix in v2 - use #define instead of enum type.

Best regards,
Milo