linux-kernel - Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2016 19:26:44 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     alsa-devel@...a-project.org,
        Banajit Goswami <bgoswami@...eaurora.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        Kenneth Westfield <kwestfie@...eaurora.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Subject: Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote:
> This patch fixes lpass-platform driver which was broken in v4.9-rc1.
> lpass_pcm_data data structure holds information specific to stream.
> Holding a single private pointer to it in global lpass_data
> will not work, because it would be overwritten by for each pcm instance.

This is a bug fix but you've made it depend on patch 1 which is just a
refactoring and should therefore not be sent to Linus as a fix.  Please
don't do this, fix bugs first then do any cleanups and new
functionality.  That way we can send fixes to Linus without needing to
pull in extra stuff.

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)