[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Fri, 28 Oct 2016 19:26:31 -0700
From: Brian Norris <computersforpeace@...il.com>
To: Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
Cc: <linux-kernel@...r.kernel.org>,
Brian Norris <computersforpeace@...il.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
SF Markus Elfring <elfring@...rs.sourceforge.net>
Subject: [PATCH] checkpatch: fix uninitialized var when run with --no-tree
From: Brian Norris <computersforpeace@...il.com>
If checkpatch.pl gets copied out of the tree, --no-tree shouldn't start
complaining:
Use of uninitialized value $root in concatenation (.) or string at
/path/to/checkpatch.pl line 764.
Let's just give the safe answer instead -- don't warn about "obsolete"
files.
Fixes: 85b0ee18bbf8 ("checkpatch: see if modified files are marked obsolete in MAINTAINERS")
Signed-off-by: Brian Norris <computersforpeace@...il.com>
---
This is a 4.9-rc1 regression
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8368d1c4348..c8cd643dbc6f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -761,6 +761,8 @@ sub seed_camelcase_file {
sub is_maintained_obsolete {
my ($filename) = @_;
+ return 0 if (!$tree);
+
return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
--
2.8.0.rc3.226.g39d4020
Powered by blists - more mailing lists