linux-kernel - Re: [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2016 05:26:02 +0800
From:   Ming Lei <tom.leiming@...il.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Alexander Graf <agraf@...e.com>, Ming@...e.de,
        <"Lei <tom.leiming"@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity

On Tue, Nov 1, 2016 at 3:37 AM, Hannes Reinecke <hare@...e.de> wrote:
> Signed-off-by: Hannes Reinecke <hare@...e.de>
> Reviewed-by: Christoph Hellwig <hch@....de>
> ---
>  drivers/block/loop.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index fa1b7a9..3008dec 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1298,7 +1298,7 @@ loop_get_status64(struct loop_device *lo, struct loop_info64 __user *arg) {
>         return err;
>  }
>
> -static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev)
> +static int loop_set_capacity(struct loop_device *lo)
>  {
>         if (unlikely(lo->lo_state != Lo_bound))
>                 return -ENXIO;
> @@ -1361,7 +1361,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode,
>         case LOOP_SET_CAPACITY:
>                 err = -EPERM;
>                 if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN))
> -                       err = loop_set_capacity(lo, bdev);
> +                       err = loop_set_capacity(lo);
>                 break;
>         case LOOP_SET_DIRECT_IO:
>                 err = -EPERM;

Reviewed-by: Ming Lei <tom.leiming@...il.com>


thanks,
Ming Lei