lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Nov 2016 02:07:09 +0100 From: Vivien Didelot <vivien.didelot@...oirfairelinux.com> To: Andrew Lunn <andrew@...n.ch> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [PATCH net-next 07/11] net: dsa: mv88e6xxx: add port link setter Hi Andrew, Andrew Lunn <andrew@...n.ch> writes: >> +#define LINK_UNKNOWN -1 >> + >> + /* Port's MAC link state >> + * LINK_UNKNOWN for normal link detection, 0 to force link down, >> + * otherwise force link up. >> + */ >> + int (*port_set_link)(struct mv88e6xxx_chip *chip, int port, int link); > > Maybe LINK_AUTO would be better than UNKNOWN? Or LINK_UNFORCED. I used LINK_UNKNOWN to be consistent with the supported SPEED_UNKNOWN and DUPLEX_UNKNOWN values of PHY devices. Thanks, Vivien
Powered by blists - more mailing lists