linux-kernel - RE: [PATCH v2 3/6] usb: ehci: fsl: use bus->sysdev for DMA configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2016 09:26:51 +0000
From:   Sriram Dash <sriram.dash@....com>
To:     Sriram Dash <sriram.dash@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
CC:     "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Suresh Gupta <suresh.gupta@....com>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "pku.leo@...il.com" <pku.leo@...il.com>,
        "Arnd Bergmann" <arnd@...db.de>
Subject: RE: [PATCH v2 3/6] usb: ehci: fsl: use bus->sysdev for DMA
 configuration

>From: Sriram Dash [mailto:sriram.dash@....com]
>From: Arnd Bergmann <arnd@...db.de>
>
>For the dual role ehci fsl driver, sysdev will handle the dma config.
>
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
>Signed-off-by: Sriram Dash <sriram.dash@....com>
>---
>Changes in v2:
>  - fix compile warnings
>
>
> drivers/usb/host/ehci-fsl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index
>9f5ffb6..4dde500 100644
>--- a/drivers/usb/host/ehci-fsl.c
>+++ b/drivers/usb/host/ehci-fsl.c
>@@ -96,8 +96,8 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev)
> 	}
> 	irq = res->start;
>
>-	hcd = usb_create_hcd(&fsl_ehci_hc_driver, &pdev->dev,
>-				dev_name(&pdev->dev));
>+	hcd = __usb_create_hcd(&fsl_ehci_hc_driver, &pdev->dev->parent,

Will correct it to "pdev->dev.parent".

>+			       &pdev->dev, dev_name(&pdev->dev), NULL);
> 	if (!hcd) {
> 		retval = -ENOMEM;
> 		goto err1;
>--
>2.1.0