[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161102225241.GA19591@remoulade>
Date: Wed, 2 Nov 2016 22:52:42 +0000
From: Mark Rutland <mark.rutland@....com>
To: Laura Abbott <labbott@...hat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>,
Will Deacon <will.deacon@....com>,
Catalin Marinas <catalin.marinas@....com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Andrew Morton <akpm@...ux-foundation.org>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Joonsoo Kim <iamjoonsoo.kim@....com>,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv2 5/6] arm64: Use __pa_symbol for _end
On Wed, Nov 02, 2016 at 03:00:53PM -0600, Laura Abbott wrote:
>
> __pa_symbol is technically the marco that should be used for kernel
> symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL.
Nit: s/marco/macro/
I see there are some other uses of __pa() that look like they could/should be
__pa_symbol(), e.g. in mark_rodata_ro().
I guess strictly speaking those need to be updated to? Or is there a reason
that we should not?
Thanks,
Mark.
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> ---
> arch/arm64/mm/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 212c4d1..3236eb0 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -209,8 +209,8 @@ void __init arm64_memblock_init(void)
> * linear mapping. Take care not to clip the kernel which may be
> * high in memory.
> */
> - memblock_remove(max_t(u64, memstart_addr + linear_region_size, __pa(_end)),
> - ULLONG_MAX);
> + memblock_remove(max_t(u64, memstart_addr + linear_region_size,
> + __pa_symbol(_end)), ULLONG_MAX);
> if (memstart_addr + linear_region_size < memblock_end_of_DRAM()) {
> /* ensure that memstart_addr remains sufficiently aligned */
> memstart_addr = round_up(memblock_end_of_DRAM() - linear_region_size,
> --
> 2.10.1
>
Powered by blists - more mailing lists