linux-kernel - Re: [PATCH 9/9] clocksource: import ARC timer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2016 19:14:52 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Vineet Gupta <Vineet.Gupta1@...opsys.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        linux-snps-arc@...ts.infradead.org,
        Noam Camus <noamca@...lanox.com>, Alexey.Brodkin@...opsys.com
Subject: Re: [PATCH 9/9] clocksource: import ARC timer driver

On Thu, Nov 03, 2016 at 06:33:17PM +0100, Daniel Lezcano wrote:

[ ... ]

> As now the clksrc-probe is correctly handling the errors, if the rtc and the
> gfrc are both defined in the DT, you can fail to init the rtc one with a simple
> test in the init function:
> 
> 	if (IS_DEFINED(CONFIG_SMP))
> 		return -EINVAL;
> 
> So, you can inconditionaly compile in both RTC and GFRC, no ? That would be
> cleaner and prevent a different kernel config.

Ah, actually I suggested something which is already there :)

Perhaps, the if SMP does not make sense in the Kconfig, no ?