lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 06 Nov 2016 18:47:41 -0800 From: Joe Perches <joe@...ches.com> To: James Simmons <jsimmons@...radead.org>, Nicholas Hanley <nicholasjhanley@...il.com> Cc: oleg.drokin@...el.com, andreas.dilger@...el.com, gregkh@...uxfoundation.org, lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote: > > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd. > Reviewed-by: James Simmons <jsimmons@...radead.org> [] > > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c [] > > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx, > > { > > __u64 *pages = tx->tx_pages; > > bool is_rx = (rd != tx->tx_rd); > > - bool tx_pages_mapped = 0; > > + bool tx_pages_mapped = 0; It's generally better to use bool assignments to true/false not 1/0.
Powered by blists - more mailing lists