linux-kernel - Re: [PATCH v2 13/15] pinctrl-sx150x: Use handle_bad_irq instead of handle_edge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2016 09:47:23 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v2 13/15] pinctrl-sx150x: Use handle_bad_irq instead of handle_edge_irq

On Mon, Nov 7, 2016 at 5:53 PM, Andrey Smirnov <andrew.smirnov@...il.com> wrote:

> Althought the function passed as a "handler" during GPIO chip
> instantiation is not going to ever be called, specifying handle_edge_irq
> there makes for a rather confusing read, both because no "ack" callback
> in specified for irqchip and because there's no acking action is
> necessary.
>
> Specify handle_bad_irq instead a make a note of the situation. This
> commit should be a no-op behaviour wise.
>
> Tested-by: Neil Armstrong <narmstrong@...libre.com>
> Acked-by: Neil Armstrong <narmstrong@...libre.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>

Patch applied!

Yours,
Linus Walleij